search

neovim / go-client

Nvim Go client
https://pkg.go.dev/github.com/neovim/go-client
Apache License 2.0
567 stars 36 forks source link

Add license header #43

Closed zchee closed 5 years ago

zchee commented 5 years ago

Add license header to apiimp.go template.

In the Apache license "APPENDIX: HOW TO APPLY THE APACHE LICENSE TO YOUR WORK" section,

The text should be enclosed in the appropriate comment syntax for the file format.

Use 2016 year, Because, in the Go language, it is customary not to change it after the year you commit the file.

justinmk commented 5 years ago

I'd suggest to remove the license from the top of all files, there is no legal reason for that. Only the LICENSE file is needed.

Use 2016 year, Because, in the Go language, it is customary not to change it after the year you commit the file.

Yes, it's unnecessary and silly ritual to "update the year". I don't know why people do that.

zchee commented 5 years ago

@justinmk

I'd suggest to remove the license from the top of all files, there is no legal reason for that. Only the LICENSE file is needed.

Yeah I know, Apache license said should. This commit is just in case. So, should I close this pull request? up to you.

Off topic, I want hear your opinions. If when adding new implementation with new file, should I also not add license header cooment? If not, the author name is I think would be better to "The go-client Authors." or "Neovim Authors" etc. because garyburd has been not a maintainers. What do you think?

Yes, it's unnecessary and silly ritual to "update the year". I don't know why people do that.

Totally agreed :P

zchee commented 5 years ago

Also,

I'd suggest to remove the license from the top of all files

If you want to it, I'll send another pull request that's remove license comment from all go files.

justinmk commented 5 years ago

If when adding new implementation with new file, should I also not add license header cooment?

Don't need license header.

Gary still has copyright on most of the code, I wouldn't bother changing it to "go client authors".

zchee commented 5 years ago

@justinmk

I see, I said

If when adding new implementation with new file, should I also not add license header cooment? If not, ...

So my concern was resolved.

You reactioned my comment. I will send pull request that remove license header from all files.

zchee commented 5 years ago

close.