search

neovim / go-client

Nvim Go client
https://pkg.go.dev/github.com/neovim/go-client
Apache License 2.0
578 stars 36 forks source link

Change `Del` prefix to `Delete` #57

Closed zchee closed 5 years ago

zchee commented 5 years ago

Change Del prefix to Delete on nvim_del_keymap and nvim_buf_del_keymap.

I made a mistake. Respect other API names.

zchee commented 5 years ago

@justinmk I think you did wait for CI results when approve this PR. (I surprised 2min approve :O) Now passed CI. So, Can I self merge if you already approved? (also in the future) If ok, seems to you did always squash merge, I respect that.

justinmk commented 5 years ago

So, Can I self merge if you already approved? (also in the future)

Yes :)

If ok, seems to you did always squash merge, I respect that.

Depends on the commits.

zchee commented 5 years ago

@justinmk

So, Can I self merge if you already approved? (also in the future)

Yes :)

Thanks! I will continue to working on the resolved of issues :)