search

neovim / go-client

Nvim Go client
https://pkg.go.dev/github.com/neovim/go-client
Apache License 2.0
578 stars 36 forks source link

Add `WindowConfig` for `OpenWindow` #63

Closed zchee closed 4 years ago

zchee commented 5 years ago

Add WindowConfig struct for OpenWindow API instead of map[string]interface. Also, added floating_window testcase.

Close: #54

zchee commented 5 years ago

@justinmk did you enjoy VimConf in Japan? :D BTW, sorry, just ping.

justinmk commented 4 years ago

@justinmk did you enjoy VimConf in Japan? :D

yes it was a good experience! were you there? :)

zchee commented 4 years ago

@justinmk

yes it was a good experience! were you there? :)

No :( I really went to go VimConf... But I am happy to hear that :D Also, your slide is very good works, interesting!!

BTW, PTAL

zchee commented 4 years ago

@justinmk Thanks re-approve! will merge

zchee commented 4 years ago

@justinmk Also, I was remove support old go versions. will cut v1.0.1 release.

justinmk commented 4 years ago

remove support old go versions

@akiyosi @dzhou121 any objection?

zchee commented 4 years ago

@justinmk dzhou121's popular repo which used neovim/go-client is here: (I don't know he have another repo used go-client)

https://github.com/dzhou121/gonvim

But IIRC has been not maintain this repo. (I think you already know) And @akiyosi forked this. also very active.

So, I think would be good to adding @akiyosi to @neovim/golang member if we will get reply cooment for

any objection?

also if he want to it.

BTW, I saw @neovim/golang team members role. Unfortunately, now have maintainer label users not maintain go-client repo, (but yes, I really respect great works. made any SDK from scratch is very hard work) that's same means of there is no go-client maintainer. So, could you change my role to Maintainer?(or adding you to Maintainer) if haven't any concerns such as neovim org policy, GitHub org permission scope or etc.

akiyosi commented 4 years ago

Hi Sorry for late reaction.

remove support old go versions

I have no objection.

So, I think would be good to adding @akiyosi to @neovim/golang member if we will get reply cooment for also if he want to it.

If I can help the project even a little, I would like to join the members.