neovim / go-client

Nvim Go client
https://pkg.go.dev/github.com/neovim/go-client
Apache License 2.0
565 stars 36 forks source link

Remove get virtual text fix extmark #78

Closed zchee closed 3 years ago

zchee commented 3 years ago

Remove get_virtual_text api and fix extmark raleted args

h-michael commented 3 years ago

@zchee It seems that we should update codecov GHA. ref: #79

zchee commented 3 years ago

@h-michael sorry for late. Your PR might be works codecov! but seems to atill draft, Can I just copy code to this PRfrom your PR, and close #79?

codecov[bot] commented 3 years ago

Codecov Report

Merging #78 (7a87a37) into master (acbae1a) will increase coverage by 1.3%. The diff coverage is 50.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #78     +/-   ##
========================================
+ Coverage    56.1%   57.4%   +1.3%     
========================================
  Files          11      11             
  Lines        2636    2124    -512     
========================================
- Hits         1479    1221    -258     
+ Misses       1021     769    -252     
+ Partials      136     134      -2     
Impacted Files Coverage Δ
nvim/apiimp.go 24.1% <50.0%> (+2.1%) :arrow_up:
nvim/plugin/plugin.go 31.5% <0.0%> (-3.9%) :arrow_down:
msgpack/encode.go 76.7% <0.0%> (-3.6%) :arrow_down:
msgpack/rpc/endpoint.go 58.0% <0.0%> (-3.2%) :arrow_down:
msgpack/decode.go 63.7% <0.0%> (-3.1%) :arrow_down:
msgpack/unpack.go 82.9% <0.0%> (-2.3%) :arrow_down:
msgpack/common.go 70.7% <0.0%> (-2.0%) :arrow_down:
nvim/plugin/main.go 31.1% <0.0%> (-0.2%) :arrow_down:
msgpack/pack.go 87.5% <0.0%> (-0.1%) :arrow_down:
nvim/nvim.go 68.8% <0.0%> (+0.1%) :arrow_up:
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update acbae1a...7a87a37. Read the comment docs.

zchee commented 3 years ago

@h-michael PTAL.