search

neovim / go-client

Nvim Go client
https://pkg.go.dev/github.com/neovim/go-client
Apache License 2.0
565 stars 36 forks source link

If CommandCompletionArgs.CursorPosString is a string, and not at int, #80

Closed WhoIsSethDaniel closed 3 years ago

WhoIsSethDaniel commented 3 years ago

msgpack consistently errors out saying it cannot convert an 'int to a string'. If you change it to an int it works as expected.

zchee commented 3 years ago

@WhoIsSethDaniel sorry for late, I'll check and test, but currently go-client have CI problem. I want to fix CI first, Could you waiting?

WhoIsSethDaniel commented 3 years ago

@WhoIsSethDaniel sorry for late, I'll check and test, but currently go-client have CI problem. I want to fix CI first, Could you waiting?

Yes I can wait

codecov[bot] commented 3 years ago

Codecov Report

Merging #80 (c03abed) into master (42f62bc) will not change coverage. The diff coverage is 0.0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #80   +/-   ##
======================================
  Coverage    57.4%   57.4%           
======================================
  Files          11      11           
  Lines        2124    2124           
======================================
  Hits         1221    1221           
  Misses        769     769           
  Partials      134     134
Impacted Files Coverage Δ
nvim/helpers.go 76.9% <0.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 42f62bc...c03abed. Read the comment docs.

zchee commented 3 years ago

@WhoIsSethDaniel fixed CI. Could you write a test case as much as possible?

zchee commented 3 years ago

@WhoIsSethDaniel never mind. I found it type is int in Neovim doc :help. Will merge and I'll write testcase.