search

neovim / neovim.github.io

Neovim website
https://neovim.io
MIT License
415 stars 100 forks source link

Update deps #350

Closed saitheninja closed 3 months ago

saitheninja commented 4 months ago

Hi. I was browsing the docs and I noticed that maybe I could help clean up some things. Related issue: #228

Things done in this pull request:

Everything built fine on my machine. The only visual change is using the Inter font. Screenshot_20240520_173925

Also there's some scripts that need to get their references updated to the correct filenames: on the main site: https://github.com/neovim/neovim/blob/40ce8577977fcdce8ad76863c70eb522e4cefd4d/scripts/gen_help_html.lua#L829 And the docs: https://github.com/neovim/doc/blob/6f805e0d6085bd29ef881dcfe907638c943aac75/templates/report-header.sh.html#L11

I can do pull requests to update those if everything looks good, I just wanted to make sure that I didn't miss anything, or do something dumb. This pull request got a little bigger than I expected.

justinmk commented 3 months ago

This is definitely wanted, but why are there 18k lines added?

saitheninja commented 3 months ago

Good question. I think that's mostly the unminified versions of bootstrap.css and bootstrap.bundle.js.

I included the unminified versions because it's easier to browse through without having to load up a dev environment. Also the repo currently has the unminified and minified versions so I was just pattern matching. But I dont have any strong feelings about including it.

Should I go ahead and remove the unminified files?

justinmk commented 3 months ago

well, if that's the case, can the old ones be removed?

saitheninja commented 3 months ago

Sure. Give me like 30 minutes and I'll clean it up.

saitheninja commented 3 months ago

Okay, cleaned it up. The diff is now much more reasonable.

Also made pull requests to update the links from the other repos to point to the correct files.