neovim / neovim

Vim-fork focused on extensibility and usability
https://neovim.io
Other
80.57k stars 5.52k forks source link

New colorscheme breaks syntax highlighting of keywords #28860

Closed 00-kat closed 2 months ago

00-kat commented 2 months ago

Problem

Things such as for, if, and other keywords have no color with the new Neovim theme.

C: image #include and int have no color.

Lua: image for, in, do, if, then, end, local, etc. have no color.

Python: image import, def, if

I'm sure you get the idea by now.

Steps to reproduce

nvim --clean
:set ft=yourfavouritelanguage
i
// type some code here

Expected behavior

Perhaps a little more color?

Here's Neovim's old colorscheme (running v0.9.5 in these screenshots): image image image

And here's the vim.lua colorscheme (I tried every other colorscheme that comes with Neovim, they all have color): image image image

Neovim version (nvim -v)

0.10.0

Vim (not Nvim) behaves the same?

No

Operating system/version

Arch Linux (rolling release)

Terminal name/version

Kitty

$TERM environment variable

xterm-kitty

Installation

System package manager (pacman), AppImage

rvolosatovs commented 2 months ago

Just updated from dd00b6b442a6d3a8a4758b0ee10ac93d07e7db72 to 0.10.0 and also experiencing this issue. I've been been using neovim pinnned to dd00b6b442a6d3a8a4758b0ee10ac93d07e7db72, since sometime after that commit, the issue appeared on nightly.

I believe the cause of this, last time I checked, was the fact that the colorschemes we are using do not support the treesitter (or was it LSP?) highlighting groups.

Interestingly, if I do something like:

:colorscheme vim
:colorscheme base16-tomorrow-night // that's the scheme I want to use

I do get most of the highlighting it seems

I also have the LSP -> treesitter hl group mapping set up as following: https://github.com/rvolosatovs/nixelium/blob/720a2167c27152e564238075f0f1b7167f7ba049/overlays/neovim/config.lua#L318-L335

This mapping may be out-of-date at this point

clason commented 2 months ago

The minimality of the default colorscheme is deliberate and not up for debate; you are welcome to keep using other themes that are more to your taste.

bew commented 2 months ago

Having a new colorscheme is great, but if it is detrimental to the default user experience I'm wondering why it was accepted..