search

neovim / node-client

Nvim Node.js client and plugin host
https://neovim.io/node-client/
MIT License
492 stars 53 forks source link

Update Neovim.ts #186

Closed KadoBOT closed 2 years ago

KadoBOT commented 2 years ago

Add style to OpenWindowOptions

rhysd commented 2 years ago

@KadoBOT Can you show a link to document of the style option in Neovim?

KadoBOT commented 2 years ago

@KadoBOT Can you show a link to document of the style option in Neovim?

:h nvim_open_win():

                              • style: Configure the appearance of the window.
                                Currently only takes one non-empty value:
                                • "minimal" Nvim will display the window with
                                  many UI options disabled. This is useful
                                  when displaying a temporary float where the
                                  text should not be edited. Disables
                                  'number', 'relativenumber', 'cursorline',
                                  'cursorcolumn', 'foldcolumn', 'spell' and
                                  'list' options. 'signcolumn' is changed to
                                  `auto` and 'colorcolumn' is cleared. The
                                  end-of-buffer region is hidden by setting
                                  `eob` flag of 'fillchars' to a space char,
                                  and clearing the |EndOfBuffer| region in
                                  'winhighlight'.

And I just noticed that border is missing as well...

rhysd commented 2 years ago

https://dev.azure.com/neovim/node-client/_build/results?buildId=216&view=logs&j=775b36c7-0acf-56fe-5683-ee983d10b23d&t=db2cdf11-2dd7-537a-2325-1e72eed53a44&l=28

Can you resolve the prettier warning?

/Users/runner/work/1/s/packages/neovim/src/api/Neovim.ts
  103:1  error  Delete `··`  prettier/prettier

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.
KadoBOT commented 2 years ago

That's what I get from using the online editor! 😅 I'll clone the repo and add the other missing fields as well.

KadoBOT commented 2 years ago

@rhysd I'm just not sure about the bufpos field, and the string[] in the border. Are those valid types on nvim?

rhysd commented 2 years ago

Yeah, I believe they are valid.

rhysd commented 2 years ago

@billyvg @justinmk Can we make a new release?

billyvg commented 2 years ago

@rhysd 4.10.1 published -- thoughts on moving to GitHub Actions? Can move add a publish workflow when we make a GitHub Release too.

rhysd commented 2 years ago

thoughts on moving to GitHub Actions?

That would be nice idea though I'm not understanding how to manage npm credentials and 2FA on GHA.

KadoBOT commented 2 years ago

thoughts on moving to GitHub Actions?

That would be nice idea though I'm not understanding how to manage npm credentials and 2FA on GHA.

You can add them under the repository settings (-> secrets). And they'll be available as env variables. Although, external PR's won't have access to those, for obvious reasons.