neovim / node-client

Nvim Node.js client and plugin host
https://neovim.io/node-client/
MIT License
476 stars 49 forks source link

Fails to replace NPM_TOKEN in yarn config #203

Closed mjholub closed 1 year ago

mjholub commented 1 year ago

When running checkhealth I got

Node.js provider (optional) ~
- Node.js: v18.16.0
- Nvim node.js host: /usr/local/lib/node_modules/neovim/bin/cli.js
- ERROR Command error (job=1411, exit code 1): `yarn info neovim --json` (in '/home/<current project's workdir>')
  output: {"type":"info","data":"If you think this is a bug, please open a bug report with the information provided in \"/home/<current workdir>/yarn-error.log\"."}{"type":"info","data":"Visit https://yarnpkg.com/en/docs/cli/info for documentation about this command."}
  stderr: {"type":"error","data":"An unexpected error occurred: \"Failed to replace env in config: ${NPM_TOKEN}\"."}
- ERROR Failed to run: yarn info neovim --json
  - ADVICE:
    - Make sure you're connected to the internet.
    - Are you behind a firewall or proxy?

The issue is rather minor, since as long as the packages are already there in node_modules things like go to definition, show refs etc. work for private symbols. The issue probably lies in the way env variables are set in Fish, to be more precise: set -U NPM_TOKEN <unquoted value>

Running checkhealth under zsh shows no problems:

Node.js provider (optional) ~
- Node.js: v18.16.0
- Nvim node.js host: /usr/local/lib/node_modules/neovim/bin/cli.js
- OK Latest "neovim" npm/yarn/pnpm package is installed: 4.10.1

Haven't had the opportunity to check any GUIs since neither zsh nor fish are my login shells (ash is), because gnvim crashed and I don't want to waste time testing something probably irrelevant while this is fairly easy to reproduce.

Other potentially relevant system info Linux pc0 6.1.27-2-lts Alpine 3.18 SMP PREEMPT_DYNAMIC x86_64, nvim 0.9.0 (Lazyvim with null-ls and tsserver), wlroots-0.16.2-r2 Fish 3.6.1, LuaJIT 2.1.0-beta3 , Alacritty 0.12.0 with tmux 3.3a_git20230428-r0
mjholub commented 1 year ago

ok the issue is with yarn itself