Example in README doesn't work

neovim / node-client

Nvim Node.js client and plugin host

https://neovim.io/node-client/

MIT License

492 stars 53 forks source link

Example in README doesn't work #273

Closed blinry closed 10 months ago

blinry commented 11 months ago

Hey :)

When we tried to run the provided example in the README (in TypeScript), we encountered three issues:

Overwriting "nvim.window" gave us a type error. We solved this by just assigning to a local variable.
Using the provided tests, the check that lines should be [""] failed for us. It actually was equal to [].
We got the error "nvim_proc.disconnect() is not a function". Not sure yet why.

Can you reproduce these errors?

justinmk commented 10 months ago

If you can provide an example that works, please send a PR.

Duplicate of https://github.com/neovim/node-client/issues/154 https://github.com/neovim/node-client/issues/41

justinmk commented 10 months ago

When we tried to run the provided example in the README (in TypeScript), we encountered three issues:

After https://github.com/neovim/node-client/pull/309 the README.md now provides a fully working self-contained example. You should be able to copy-paste the code and run it immediately.