fix: getNvimFromEnv returns invalid Nvim in matches

neovim / node-client

Nvim Node.js client and plugin host

https://neovim.io/node-client/

MIT License

464 stars 49 forks source link

fix: getNvimFromEnv returns invalid Nvim in matches #308

Closed justinmk closed 5 months ago

justinmk commented 5 months ago

Problem: If a found "nvim" does not meet minVersion, it's included in both matches and unmatchedVersions. It should only be included in unmatchedVersions.

Solution:

If a found "nvim" is broken or does not meet minVersion, do not include it in matches.
Merge the unmatchedVersions and errors collections into a single invalid list.