Closed fidgetingbits closed 4 weeks ago
this probably means the npm version
step in https://github.com/neovim/node-client?tab=readme-ov-file#release needs to be updated or another step added. please test if the npm version
invocation there also updates the version field you have added here
this probably means the
npm version
step in https://github.com/neovim/node-client?tab=readme-ov-file#release needs to be updated or another step added. please test if thenpm version
invocation there also updates the version field you have added here
Thanks. Unfortunately it does not. I've changed the root package.json to match the prerelease version from packages/neovim/package.json now, and also added the two commands to the README as suggested.
Originally I thought of adding something like this:
"update-version": "npm version patch && npm version -w packages/neovim patch",
"prerelease-version": "npm version --no-git-tag-version prerelease --preid dev && npm version -w packages/neovim --no-git-tag-version prerelease --preid dev"
to the root package.json scripts, but from a quick glance it doesn't seem like there is a good way to pass multiple/optional arguments to npm scripts, so wouldn't be pleasant if you need to bump the major/minor version.
This seems like a problem with the nix tooling, since the root package.json doesn't really map to an actual package. But we can try this for now. I need to get a deeper understanding of npm "monorepo" conventions.
Ok, appreciate it. Now that this is merged I'll send a PR to nixpkgs for the new package, and I'll mention this issue to see if someone more familar than me with nix node packaging can clarify if this is a nix problem or not, and I'll let you know.
I'm trying to build node-client on nix using buildNpmPackages, as nix is migrating away from the old way of building node packages, and I get the following:
This seems to be solved simply by adding the name/version into package.json, which this PR does. I've confirmed that the it builds/works correctly with this change, so didn't investigate what exact command was causing the issue in the install hook.