search

neovim / nvim-lspconfig

Quickstart configs for Nvim LSP
Apache License 2.0
10.64k stars 2.08k forks source link

html-lsp: "cannot read null 'validProperties'" when opening a html file with CSS <style> tag #3393

Open adamrokickirns opened 4 days ago

adamrokickirns commented 4 days ago

Description

Opening a html file that contains embedded CSS in it throws the following error:

[ERROR][2024-10-23 01:56:57] ...lsp/handlers.lua:623    "Error while validating file:///home/user/code/test.html: Cannot read properties of null (reading 'validProperties')
TypeError: Cannot read properties of null (reading 'validProperties')
    at LintConfigurationSettings.getSetting (/home/user/.local/share/nvim/mason/packages/html-lsp/node_modules/vscode-langservers-extracted/node_modules/vscode-css-languageservice/lib/umd/services/lintRules.js:78:29)
    at new LintVisitor (/home/user/.local/share/nvim/mason/packages/html-lsp/node_modules/vscode-langservers-extracted/node_modules/vscode-css-languageservice/lib/umd/services/lint.js:53:41)
    at LintVisitor.entries (/home/user/.local/share/nvim/mason/packages/html-lsp/node_modules/vscode-langservers-extracted/node_modules/vscode-css-languageservice/lib/umd/services/lint.js:41:29)
    at CSSValidation.doValidation (/home/user/.local/share/nvim/mason/packages/html-lsp/node_modules/vscode-langservers-extracted/node_modules/vscode-css-languageservice/lib/umd/services/cssValidation.js:34:60)
    at _callee$ (/home/user/.local/share/nvim/mason/packages/html-lsp/node_modules/vscode-langservers-extracted/lib/html-language-server/modes/cssMode.js:53:69)
    at tryCatch (/home/user/.local/share/nvim/mason/packages/html-lsp/node_modules/vscode-langservers-extracted/node_modules/regenerator-runtime/runtime.js:64:40)
    at Generator.invoke (/home/user/.local/share/nvim/mason/packages/html-lsp/node_modules/vscode-langservers-extracted/node_modules/regenerator-runtime/runtime.js:299:22)
    at Generator.next (/home/user/.local/share/nvim/mason/packages/html-lsp/node_modules/vscode-langservers-extracted/node_modules/regenerator-runtime/runtime.js:124:21)
    at asyncGeneratorStep (/home/user/.local/share/nvim/mason/packages/html-lsp/node_modules/vscode-langservers-extracted/lib/html-language-server/modes/cssMode.js:17:103)
    at _next (/home/user/.local/share/nvim/mason/packages/html-lsp/node_modules/vscode-langservers-extracted/lib/html-language-server/modes/cssMode.js:19:194)"

Putting this in the config fixes it:

        html = {
          settings = {
            css = {
              lint = {
                validProperties = {},
              },
            },
          },
        }
glepnir commented 3 days ago

this error from the server . can you try a minimal config ?

justinmk commented 3 days ago

That seems like a UX bug in the lsp server, but updating the default config as you've done could be a worthwhile change in the config. PR welcome