search

neovim / pynvim

Python client and plugin host for Nvim
http://pynvim.readthedocs.io/en/latest/
Apache License 2.0
1.48k stars 118 forks source link

Drop support for Python 2 and 3.4 (type annotations)? #422

Closed blueyed closed 12 months ago

blueyed commented 4 years ago

I'm looking into adding type annotations, and would like to do this for Python 3.5+ then.

Both Python 2 and 3.4 are EOL by now, and it might take time anyway to merge type annotations then anyway.

What do you think?

bfredl commented 4 years ago

Dropping support for python 2 on master is fine. We could create a separate maintenance branch for bug-fixes only on top of 0.4.0 (or whatever the last python 2 version)

blueyed commented 4 years ago

Ok, what about Python 3.4?

bfredl commented 4 years ago

Same thing there, python 3.4 can stay on 0.4.0/maintenance branch (if anyone still uses it). Lets move master forward.

blueyed commented 4 years ago

Cool. No need to do this already, but good to know how to proceed in this regard.

noelevans commented 4 years ago

Would you be able to accept help doing this if it were to be delivered module-by-module? If so is there any particular order to follow?

blueyed commented 4 years ago

@noelevans I think "removing support" is not a goal, but should be done when it gets into the way somewhere. Then it is as easy as removing the classifiers and CI config, so it's not really a task by itself.

farisachugthai commented 3 years ago

Alternatively, if python2 support is desirable so as to not phase out support for entirely for type annotations, typing is a pip installable library on python<3.5.

https://mypy.readthedocs.io/en/latest/python2.html

So we could add it as an install_requirement in the setup.py if sys.version < (3,5):