Set unicode_errors in Unpacker

neovim / pynvim

Python client and plugin host for Nvim

http://pynvim.readthedocs.io/en/latest/

Apache License 2.0

1.48k stars 118 forks source link

Closed Shougo closed 4 years ago

Shougo commented 4 years ago

Fix #438

tjdevries commented 4 years ago

@teto do you have permissions to merge here or no?

jamessan commented 4 years ago

Is there a test that can be added for this, similar to test_invalid_utf8 in test_buffer.py?

teto commented 4 years ago

@tjdevries nope :(

Shougo commented 4 years ago

Is there a test that can be added for this, similar to test_invalid_utf8 in test_buffer.py?

I think the tests are already added. But msgpack 0.6.2 is used in previous CI. https://travis-ci.org/github/neovim/pynvim/jobs/647230783

Shougo commented 4 years ago

Travis CI tests are not executed in current PR. Why?

Shougo commented 4 years ago

Note: msgpack 1.0 is released in Feb17.

pynvim's last commit is Feb 7. Oh...

jamessan commented 4 years ago

Ok, so re-running a job from the last master commit shows the timeout failure, since it's now running against msgpack 1.0.

This branch doesn't hit the timeout, but it does fail the invalid utf8 test.

Shougo commented 4 years ago

OK. I will check it.

Shougo commented 4 years ago

I have fixed the error.

Shougo commented 4 years ago

Fixed Python 2.7 unicode_errors.

Shougo commented 4 years ago

Thank you!