search

neovim / pynvim

Python client and plugin host for Nvim
http://pynvim.readthedocs.io/en/latest/
Apache License 2.0
1.48k stars 118 forks source link

Close #450: Modify all imports in the repository to absolute imports #451

Closed farisachugthai closed 3 years ago

farisachugthai commented 3 years ago

@Shougo I realized that going ahead and changing all the imports wouldn't be very time intensive so I did.

In addition, I have verified that tests still pass with pytest in a venv.

However, I would like to note that:

python -m doctest pynvim/msgpack_rpc/event_loop/base.py

currently fails. There's a circular import issue, and even if that was resolved, it seems that Tracebacks were copy-pasted into BaseEventLoop.__init__().

However that may be an issue for a different PR, and the imports mentioned in #450 are fixed

farisachugthai commented 3 years ago

I just noticed that Travis CI failed. After switching to absolute imports, the imports were in the incorrect order and flake8 failed as a result. Added 1 commit to fix this

justinmk commented 3 years ago

Thanks for working on this!