search

neovim / pynvim

Python client and plugin host for Nvim
http://pynvim.readthedocs.io/en/latest/
Apache License 2.0
1.48k stars 118 forks source link

Pypi metadata - #458 #462

Closed farisachugthai closed 12 months ago

farisachugthai commented 3 years ago

Sorry about the confusion guys. I opened #458 and committed it all to master. I didn't realize that rewinding the commits and force pushing them automatically closed the pull request, so I began doing that when I wanted to work on other parts of this repo.

This was simply a misunderstanding on how github handles pull requests, and I realized that it's WAY easier to handle things cleanly on all separate branches.

So with that being said, I'm resubmitting the commits from #458 and wanna apologize for my confusion in this.

bfredl commented 3 years ago

No worries, we are indulging hacktoberfest as an allowed fun (temporarily).

farisachugthai commented 3 years ago

Hahaha FWIW this wasn't a hacktoberfest thing. I genuinely misunderstood how GitHub handled committing directly to master and accidentally closed my own PRs but I'm also glad to see that there's some interest in this PR (at least I think).

justinmk commented 12 months ago

Looks mostly out of date, but an updated (and perhaps more minimal) PR would be welcome.