neovim / pynvim

Python client and plugin host for Nvim
http://pynvim.readthedocs.io/en/latest/
Apache License 2.0
1.48k stars 118 forks source link

ci: use tox in GitHub Actions, fix mypy warnings #469

Closed jamessan closed 12 months ago

jamessan commented 3 years ago

Example run: https://github.com/jamessan/pynvim/actions/runs/382403759

justinmk commented 12 months ago

Rebased. (Previous: https://github.com/neovim/pynvim/pull/469/commits/85d3756e2ffcb11ee492273a2e29e143b005acb1 )

wookayin commented 9 months ago

By the why are we using tox? rather than just running pytest, linters directly? etc. I find tox makes debugging CI much harder.

justinmk commented 9 months ago

By the why are we using tox? rather than just running pytest, linters directly? etc. I find tox makes debugging CI much harder.

No objection to removing it.

wookayin commented 9 months ago

Hmm I find that using tox makes running tests on multiple python versions easy. Now I'm happy with keeping it (made some improvements, #536) The only issue I have now is that tox unfortunately silences and suppresses all the pytest output despite -s --verbose option, but this is something we can figure out in the future.