search

neovim / pynvim

Python client and plugin host for Nvim
http://pynvim.readthedocs.io/en/latest/
Apache License 2.0
1.47k stars 118 forks source link

Revert "fix: vim.eval('v:true') should return python bool #506" #562

Closed samuelqp closed 3 months ago

samuelqp commented 3 months ago

This reverts commit d549371b6fb647304cff5f88a71e2bc42d2ed30a. This fixes #523 and make UltiSnips usable. As mentioned by @jsr-p, the extra check is redundant and is not worth the slower performance.

samuelqp commented 3 months ago

The checks are failing even without the changes that I made (when the fork is identical to the current upstream) (https://github.com/samuelqp/pynvim/actions/runs/8304465825).

justinmk commented 3 months ago

Thanks for the PR!

The tests are broken because they refer to a (internal) function that was removed in https://github.com/neovim/neovim/commit/eb5d15e3838f53e2fcd25989c88db87458e9f984 Fixed in https://github.com/neovim/pynvim/pull/563 , would you mind rebasing ?

samuelqp commented 3 months ago

Thanks! Seems good now.

justinmk commented 3 months ago

One more ask: can you add a "Known issues" section after this section which explains this quirk? So that we don't get repeat reports of https://github.com/neovim/pynvim/pull/506

samuelqp commented 3 months ago

One more ask: can you add a "Known issues" section after this section which explains this quirk? So that we don't get repeat reports of #506

Done