ci: don't run on push - Githubissues

neovim / tree-sitter-vimdoc

Tree-sitter parser for Vim help files

Apache License 2.0

97 stars 13 forks source link

ci: don't run on push #122

Closed dundargoc closed 6 months ago

dundargoc commented 6 months ago

There's no real reason to run on push as we're not using any caching.

justinmk commented 6 months ago

It's good to save CI time, but for low-activity repos I think we should err on the side of explicitness.

Reasons in favor of CI on push:

to have a baseline, so one can see the history of status checks by looking at master (including squash-merged PRs)
for any (rare) commits that skip the PR process

Without this, we don't have a clear concept of "current status", except whatever the last PR was (which also assumes a linear history).

dundargoc commented 6 months ago

Yeah, that's a fair point. I was mostly focused on reducing CI time for the organization but having it run on master is probably more valuable like you said. I've reverted it in https://github.com/neovim/tree-sitter-vimdoc/pull/123