search

neovim / tree-sitter-vimdoc

Tree-sitter parser for Vim help files
Apache License 2.0
106 stars 13 forks source link

`:help` docs look broken #128

Closed AlexKurisu closed 8 months ago

AlexKurisu commented 8 months ago

NVIM v0.10.0-dev-2590+g8955cef0c6. :help docs look broken. :help vim.diagnostic.Opts, for example, looks like this: image This is not a colorscheme problem as nothing changes after switching to :colorscheme default

justinmk commented 8 months ago

Don't think this is related to the grammar (this repo), unless https://github.com/neovim/tree-sitter-vimdoc/pull/125 was already added to Nvim and caused a regression? @ObserverOfTime

clason commented 8 months ago

Can confirm @ObserverOfTime

AlexKurisu commented 8 months ago

unless #125 was already added to Nvim and caused a regression

I use https://github.com/nvim-treesitter/nvim-treesitter and it is updated to commit 90a396267e117835c778bdbda6f7db86b601d829 there

ObserverOfTime commented 8 months ago

Works on my machine :thinking: image

ObserverOfTime commented 8 months ago

If the parser works then it's likely an issue with the tooling. I'll update Neovim to HEAD and check.

AlexKurisu commented 8 months ago

If the parser works then it's likely an issue with the tooling. I'll update Neovim to HEAD and check.

I have tree-sitter 0.22.1 if that matters

ObserverOfTime commented 8 months ago

Yep, worked on neovim/neovim@6d680d9 (last commit I'd built) but is broken on neovim/neovim@8955cef. I believe this needs to be fixed in Neovim (likely just an update) and there's nothing to be done here.

clason commented 8 months ago

@AlexKurisu can you try the latest commit?

ObserverOfTime commented 8 months ago

Ackshually, some docs have multiple modelines. :nerd_face:

clason commented 8 months ago

Yep, worked on neovim/neovim@6d680d9 (last commit I'd built) but is broken on neovim/neovim@8955cef. I believe this needs to be fixed in Neovim (likely just an update) and there's nothing to be done here.

Please bisect then. The last commit is unrelated.

AlexKurisu commented 8 months ago

@AlexKurisu can you try the latest commit?

I don't know how :(

clason commented 8 months ago

Rather unsurprisingly, it's https://github.com/neovim/neovim/commit/cb46f6e467268edf917cc3617b4c024a66b256de

@gpanders

ObserverOfTime commented 8 months ago

Rather unsurprisingly, it's neovim/neovim@cb46f6e

Yeah I figured that was one of the likely candidates.

clason commented 8 months ago

https://github.com/neovim/neovim/issues/27853 is the upstream issue.

(Note that the queries bundled in Neovim -- which differ from those here -- do not have this issue, so copying those to your config is a workaround in the meantime.)

justinmk commented 8 months ago

@clason is there somewhere that explains https://github.com/neovim/tree-sitter-vimdoc/commit/3089b7931809c1efd319f2d487baeb6719fdb6b5 and/or why it was also reverted?

clason commented 8 months ago

Nothing explains that commit, which is why I immediately reverted it. I would have force-pushed to erase it from existence if that were allowed.