feat!: support only "-", "•" as listitem, constrain (argument) definition

[justinmk]

Problem

• "+" and "*" have many false-positives and aren't commonly used as a listitem prefix.
• (argument) supports whitespace but,
  • that isn't actually expected by vim's :help syntax definition
  • it causes line-eating error nodes in various cases where a random { is used in text

Solution

• remove support for "+" and "*" as listitem prefixes
• disallow whitespace in (argument)

fixes https://github.com/neovim/tree-sitter-vimdoc/issues/96

[clason]

@justinmk can we get this in for 2.0.0/Nvim 0.9, even as a partial fix? Seems like the code should work?

[justinmk]

Why is this a priority for nvim 0.9? AFAIR this change wasn't as easy as it looks, though I can try to look at it in a few days

[clason]

Not a priority, just nice to have (and marked as a breaking change, so could be rolled into the 2.0.0 release).

[justinmk]

This is in decent shape now and fixes #96 .

✅ It causes some errors in the generated help, need to double-check that.

[clason]

any follow-ups planned? otherwise I'd cut a release and bump the bundled parser.

[justinmk]

Yeah I think we should get https://github.com/neovim/tree-sitter-vimdoc/pull/103 in before releasing.

[clason]

That one has a bunch of regressions, unfortunately. I'd prefer to tackle this in smaller steps, fwiw. Let's see how it looks after a rebase, though.

[justinmk]

Yeah, no objection to releasing.

[clason]

Release early, release often ;)

(I'm trying to poke tree-sitter into making more regular releases from their parsers; right now, we're either stuck in 2021 -- worst timeline -- or need to track HEAD even for releases.)

In any case, not really urgent; that was meant more as an offer to take things off your plate.