Search by customer - Githubissues

neovintage / zoho_invoice

Wrapper around the Zoho Invoice API

MIT License

6 stars 10 forks source link

Search by customer #2

Closed jer-k closed 11 years ago

coveralls commented 11 years ago

Coverage decreased (-0.39%) when pulling 0e8d0021ca3f237ce1c397ea1fa15fd90f70003e on jer-k:search-by-customer into 97bf15f3ddd1ccede3f7f881a77935be66077e40 on neovintage:master.

neovintage commented 11 years ago

You need to test is if there's a client error in the class method in the invoice and in the collection

neovintage commented 11 years ago

We should probably catch the Faraday errors and actually throw our own ZohoInvoice Client error or something that like. It would make it easier to know if something went wrong rather than returning empty arrays.

neovintage commented 11 years ago

Not going to merge. I'm going to close this one because it looks like you started to do the error stuff in another pull request.