search

neowiremod / neowire

Garry's Mod add-on that allows users to wire up components in order to make more elaborate automatic and user-controlled contraptions.
Apache License 2.0
0 stars 0 forks source link

Disallow parenting props to holograms #16

Open Vurv78 opened 6 months ago

Vurv78 commented 6 months ago

What is the problem this feature would solve?

https://github.com/wiremod/wire/pull/2945

What is the feature you are proposing to solve the problem?

Disallowing parenting props to holos, which I think is the simpler and better solution to the issue, instead of nerfing holos.

The reason this wasn't done in wiremod was because of contraptions relying on this behavior.

Consensus on the discord was that this behavior should never have been allowed in the first place.
So I think it's well within the philosophy of the fork to remove the behavior, since it only stayed in place for backwards compatibility.

What alternatives have you considered?

Not allowing parenting holograms to players

Fasteroid commented 6 months ago

Disallowing parenting holos to players other than yourself would probably be better for backwards-compat while still solving the issues put forth in https://github.com/wiremod/wire/pull/2945

Vurv78 commented 6 months ago

Disallowing parenting holos to players other than yourself would probably be better for backwards-compat while still solving the issues put forth in wiremod#2945

It would be, but still, a lot of players do rely on parenting holos to people for cosmetics or maybe things like speech bubbles and I see it as harmless. Pretty sure people in the discord agreed that parenting props to holograms should never have been a feature. I've also not heard much on the side of how parenting props to holos is necessary to use for non-exploitative reasons.

So even if it might break more contraptions (still not sure about how many people really rely on parenting to holos) in comparison to nerfing holos, I think it's more sane to go about it this way.