neowutran / ShinraMeter

Tera DPS Meter
https://neowutran.ovh/updates/?C=M;O=D
MIT License
114 stars 80 forks source link

[Request] Cut chat debuff information output #270

Closed careful7j closed 7 years ago

careful7j commented 7 years ago

Please add a file where we can override Debuff names and output format of {debuff_list}. It's too much of text (especially on Russian localization) like:

Ослабляющее тройное возмездие VI 66.5% (00:40) | Милосердие кузнеца 33.3% (00:20) | e.t.c.

  1. Some skill names are Loooooooong ('Ослабляющее тройное возмездие' - just OMG) can I somewhere in Shinra modify this skill names?
  2. Time (00:40) is also consuming space in chat (I Believe percentage (66.5%) could be just enough)
  3. Skilll level in chat "VI" <- something I defenetely don't need.

Perfect output would look like: Возмездие 66.5% | Милосердие 33.3% | e.t.c.

Please save my chat from garbage :D Thank you for the job already done, Shinra the best :)

Owyn commented 7 years ago

+1

Gl0 commented 7 years ago

Don't see the way to create short name automatically, but I can add short name to meter, if someone send me override file (something like hotdot-short-RU.tsv) in format

<id> <short name>

Not sure, where to add it, to DB (so that it will autoupdate with meter) or to user config, so that user changes to this file will be persistent.

Owyn commented 7 years ago

Alternatively - could you do a priority for displaying debuffs? like "Милосердие кузнеца" and Velika's Mark of Archer is pretty worthless to know, but on the other hand debuffs of healers and then tanks are very important to know: see, useless stuff now comes first and important one gets cut tera_screenshot_20161213_213422_proc

Gl0 commented 7 years ago

Again, don't see the way to prioritize it automatically. Now it's shown in order of appearing on boss. override file is probably the best way, cause there is not so many debuffs available on boss and it can be written manually.

careful7j commented 7 years ago

And what about modifying the output schema - "debuff name" + "debuff level" + "percentage" + "time" - is there any xml file where can I find it and fix the way I Like?

Gl0 commented 7 years ago

I'll strip time in next release, "debuff name"+"debuff level" is actually debuff name, will be substituted with short name, if we implement overrides

Owyn commented 7 years ago

I'll strip time in next release

but time is needed ...

not only percents, by time we can see how much procs there was like if it's 0:20 - hurricane proced just once, both percentage and time are needed to be shown

I think just short names would do the trick and there won't be anymore "message length limit" problem

Gl0 commented 7 years ago

The only way I see - add something like {debuff_list_p} for only % output

Owyn commented 7 years ago

The only way I see - add something like {debuff_list_p} for only % output

How would people know to what debuff the % belongs then?...

Gl0 commented 7 years ago

I've mean without time version

Owyn commented 7 years ago

I wonder if people would use that {debuff_list_p} ...

@careful7j wrote about changing the whole hardcoded schema for debuff_list display, not really about one specific variation without time

Gl0 commented 7 years ago

You see one as issue starter.=)

Gl0 commented 7 years ago

Still need someone to supply desired short names for debuffs, that will be understandable for the majority of meter users in the region.

Owyn commented 7 years ago

@Gl0 Can you dump a file with full names so people would just edit those to desired? That'd be the easiest way

Gl0 commented 7 years ago

All full names and id's are in ./resources/data/hotdot/hotdot-RU.tsv I don't know which debuffs can be placed on boss, you should know it better, cause you see them every day in dungeons. (No need to list all names, need only those, which are too long to be used as is)

Owyn commented 7 years ago

So you do have skill descriptions.. but when I hover buffs in shinra window they don't show any description up...

Gl0 commented 7 years ago

Description is shown when hovering over debuff name. Id is shown on uptime %

careful7j commented 7 years ago

I'll try to collect long debuff names today and publish it here in the end of the day.

And well... as "Owyn" mentioned above, for some debuffs time is more important than precentage (i.e. Hurricane). Looks like there it's not that easy task. Owyn, are there any more debuffs except Hurricane that are important to have time?

Owyn commented 7 years ago

are there any more debuffs except Hurricane that are important to have time?

can't recall any

I'll try to collect long debuff names today and publish it here in the end of the day.

don't forget tank debuffs of: brawler lancer warrior (tank-stance) berserker (tank-stance)

Owyn commented 7 years ago

@Gl0

Again, don't see the way to prioritize it automatically. Now it's shown in order of appearing on boss.

Some sort of sorting would be nice:

to always have priest debuffs come first, then mystic, then tank etc,

else people would be always confused searching for debuff names in unknown places when trying to know the uptime, - it's like if DPS was always shown in different place every fight (or for every player lol) (at the start, or in the middle, or at the end)

Gl0 commented 7 years ago

I can sort it by player class, but ingame order of classes is far from what you want. Also can sort it by uptime % (same as on moongourd)

Owyn commented 7 years ago

Well, sorting by uptime is better than how it is currently, so yes please.

careful7j commented 7 years ago

Yesterday collected this (after -> suggested short version): Ослабляющий град проклятий -> Град проклятий Ослабляющее тройное возмездие -> Тройное Броня: ураган -> Ураган Милосердие кузнеца -> ВМ8 Прорезающий выпад -> Прорезающий Серия взрывных ударов -> Серия Do you need it's Ids in File or names are enough?

Owyn commented 7 years ago

Ослабляющий град проклятий -> Град Ослабляющее тройное возмездие -> Возмездие Прорезающий выпад -> Выпад

better this way :-)

careful7j commented 7 years ago

Ослабляющий град проклятий -> Град Ослабляющее тройное возмездие -> Тройное Броня: ураган -> Ураган Милосердие кузнеца -> ВМ8 Прорезающий выпад -> Выпад Серия взрывных ударов -> Серия Клеймо велики -> Клеймо Карающий удар -> Карающий Okay, updated +archer/berserker one (now it's everything I believe)

Owyn commented 7 years ago

Ослабляющее тройное возмездие -> Тройное

Ослабляющее тройное возмездие -> Возмездие

Милосердие кузнеца -> ВМ8

Милосердие кузнеца -> Милосердие

(not much longer)

careful7j commented 7 years ago

Возмездие

May look confusing, but if you don't think so - I don't care. Isn't 'ВМ8' shorter? However don't care again - let it be as you like if you are sure.

Owyn commented 7 years ago

May look confusing

It's pretty unique word related to priest, no?

Тройное

Much more confusing in my opinion, could mean anything by "triple"

Thank you for gathering short names btw.

careful7j commented 7 years ago

Ослабляющий град проклятий -> Град Ослабляющее тройное возмездие -> Возмездие Броня: ураган -> Ураган Милосердие кузнеца -> ВМ8 Прорезающий выпад -> Выпад Серия взрывных ударов -> Серия Клеймо велики -> Клеймо Карающий удар -> Карающий

Finally :)