Initiaite React + TS project

binamkayastha commented 3 months ago

I think this is good, and requesting Christina to take a look and review to approve.

christikaes commented 3 months ago

Thanks for setting this up @hems-bhandari! I like that you used typescript and vite. A few things I would recommend:

(MUST DO) use pnpm (it's faster than npm/yarn) You can use pnpm create vite nepalingo --template react-ts (https://github.com/vitejs/vite/tree/main/packages/create-vite)
add an example of sample react component with CSS modules (https://vitejs.dev/guide/features#css-modules) so that we can setup the folder structure and so that the students can follow those patterns.
add a vscode automatic linting settings
(MUST DO) update the readme to explain the project + recommend to use vscode as the editor

I marked the ones that are a 'Must Do' before merging, the others can be follow-up tickets if it's not quick.

hems-bhandari commented 3 months ago

I have made the changes. Please take a look.

cloudflare-workers-and-pages[bot] commented 3 months ago

Deploying nepalingo with Cloudflare Pages

Latest commit:	`20cb4cc`
Status:	🚫 Build failed.

View logs

hems-bhandari commented 3 months ago

I had not worked with linting and eslint before. I have tried to make some changes by referencing from the docs. However, upon running pnpm run lint, it throws an error for some reason. Please take a look.

binamkayastha commented 3 months ago

Usually the person who create the PR is the one that merges it, but I'm merging it as an exception because it is blocking some of the other tickets.

nepalcodes / nepalingo

Initiaite React + TS project #18

Deploying nepalingo with Cloudflare Pages