search

nepalcodes / nepalingo

A website to learn the indigenous language of Nepal.
1 stars 1 forks source link

updated the card component #86

Closed sirElvin closed 2 weeks ago

sirElvin commented 2 weeks ago

here i have made the prounounciation and imageurl optional, and i've used fontawesome logo,

christikaes commented 2 weeks ago

Can you update your original PR pls? https://github.com/nepalcodes/nepalingo/pull/84 that way we can see what lines changed on each comment

binamkayastha commented 2 weeks ago

Like Christina Didi said, you don't have to create a new PR (Github pull request) every time you update your code. Once you create a branch and a PR, to update the PR, make your changes, run git commit -m "message" (on the same branch), and then run git push. This will automatically update the PR. Since you have two branches here, I recommend either manually copy pasting to the the card_branch branch, or if you want to do this the git way you can: 1) git checkout card_branch 2) git merge sirElvin:card_3 # this will merge sirElvin:card_3 branch into card_branch 3) Fix any merge conflicts if any 4) git push # this will update the card_branch and the other PR 5) Close this PR

If there were another reason you opened this PR, I'd love to know why to understand what you were trying to do! If you are confused and can't find a time to go over this with Christina or I, please reach out to Hems who understands git/github well as it may be a bit easier to find time with him!