nephila / django-app-helper

Helper for Django applications development
https://django-app-helper.readthedocs.io
GNU General Public License v2.0
30 stars 17 forks source link

fix: As of django-filer 3.0 mptt is not needed as a dependency #224

Closed fsbraun closed 1 year ago

fsbraun commented 1 year ago

Description

Describe:

Checklist

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 33.33% and project coverage change: -0.24 :warning:

Comparison is base (1bba8eb) 92.68% compared to head (264b1bd) 92.45%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #224 +/- ## =========================================== - Coverage 92.68% 92.45% -0.24% =========================================== Files 9 9 Lines 793 795 +2 Branches 124 125 +1 =========================================== Hits 735 735 - Misses 22 23 +1 - Partials 36 37 +1 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `92.45% <33.33%> (-0.24%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nephila#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/nephila/django-app-helper/pull/224?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nephila) | Coverage Δ | | |---|---|---| | [app\_helper/utils.py](https://app.codecov.io/gh/nephila/django-app-helper/pull/224?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nephila#diff-YXBwX2hlbHBlci91dGlscy5weQ==) | `92.97% <33.33%> (-0.78%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

yakky commented 1 year ago

@fsbraun thanks, I merged it with #226 and released version 3.3.1