nephila / django-meta

Pluggable app to allow Django developers to quickly add meta tags and OpenGraph, Twitter, and Google Plus properties to their HTML responses.
https://django-meta.readthedocs.io
Other
480 stars 68 forks source link

Replace usage of ugettext lazy #132

Closed petermorrowdev closed 2 years ago

petermorrowdev commented 2 years ago

Description

Describe:

Replaces django.utils.translation.ugettext_lazy with django.utils.translation.gettext_lazy

References

Fixes #130

Checklist

karbassi commented 2 years ago

LGTM. 👍🏽

Would be awesome if you could merge this.

petermorrowdev commented 2 years ago

@yakky Do you need me to add anything else in this PR to merge? The changes are very simple.

rhimmelbauer commented 2 years ago

@peterth3 thanks for putting in the fix!. @yakky do you have an ETA for merging and releasing a new version?

urlsangel commented 2 years ago

Hi @yakky

+1 on @rhimmelbauer's question: https://github.com/nephila/django-meta/pull/132#issuecomment-1083417296

This is blocking an update for a Django 4 project I'm working on, it would be awesome if this could be released to PYPI?

Thanks,

Russell.

ZainJaffer commented 2 years ago

+1 here, I have a project that's currently blocked - any updates on this?

afdy commented 2 years ago

+1 please merge.

Is this project still maintained or am I missing something? :)

petermorrowdev commented 2 years ago

@yakky I am assuming that this PR is stuck because of the incomplete tasks on my PR, so I added a change file and tried following your process the best I could. Please let me know if there are any other changes you need to merge this or if there's anything I can do to help.

The last release for django-meta was almost 2 years ago, so it would be awesome to see a new release with this change sometime soon.

coveralls commented 2 years ago

Coverage Status

Coverage remained the same at 98.592% when pulling f1ea7e1067d633a443fa38d69af77ff66471bf46 on peterth3:bugfix/issue-130-ugettext_lazy into f65e81c0f81cb04148ae0e2fc7dc59a6f3231729 on nephila:develop.

codecov[bot] commented 2 years ago

Codecov Report

Merging #132 (fbf79c7) into develop (8894fa7) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #132   +/-   ##
========================================
  Coverage    98.02%   98.02%           
========================================
  Files            8        8           
  Lines          456      456           
  Branches        53       53           
========================================
  Hits           447      447           
  Misses           6        6           
  Partials         3        3           
Flag Coverage Δ
unittests 97.80% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
meta/settings.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8894fa7...fbf79c7. Read the comment docs.

yakky commented 2 years ago

@peterth3 thanks a lot for your contribution. Expect a release in the next couple of days