nephila / django-meta

Pluggable app to allow Django developers to quickly add meta tags and OpenGraph, Twitter, and Google Plus properties to their HTML responses.
https://django-meta.readthedocs.io
Other
480 stars 68 forks source link

Merge #134 #137

Closed yakky closed 2 years ago

yakky commented 2 years ago

Description

Use the correct setting name (USE_SITES instead of META_USE_SITES) from the correct setting module (meta.settings instead of django.conf.settings)

References

Fix #133

Fix #134

Checklist

codecov[bot] commented 2 years ago

Codecov Report

Merging #137 (859c7b3) into develop (e141c39) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #137   +/-   ##
========================================
  Coverage    98.02%   98.02%           
========================================
  Files            8        8           
  Lines          456      456           
  Branches        53       53           
========================================
  Hits           447      447           
  Misses           6        6           
  Partials         3        3           
Flag Coverage Δ
unittests 97.80% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
meta/models.py 94.04% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e141c39...859c7b3. Read the comment docs.

yakky commented 2 years ago

Some additional test fixes have been needed