nephila / django-meta

Pluggable app to allow Django developers to quickly add meta tags and OpenGraph, Twitter, and Google Plus properties to their HTML responses.
https://django-meta.readthedocs.io
Other
480 stars 68 forks source link

Fix request set order in Meta.__init__ #156

Closed yakky closed 1 year ago

yakky commented 1 year ago

Description

Move setting Meta.request at the start of init method, to be able to use request object when setting other attributes

References

Fix #155

Checklist

coveralls commented 1 year ago

Coverage Status

coverage: 98.246%. remained the same when pulling b522c756f5254d81ea700233dacc781d504faa30 on bugfix/issue-155-request-init into d009b7ddb6539252ee8b51e3c9591c5768f15fcf on develop.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (d009b7d) 97.58% compared to head (b522c75) 97.58%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #156 +/- ## ======================================== Coverage 97.58% 97.58% ======================================== Files 8 8 Lines 456 456 Branches 78 78 ======================================== Hits 445 445 Misses 8 8 Partials 3 3 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `97.36% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nephila#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/nephila/django-meta/pull/156?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nephila) | Coverage Δ | | |---|---|---| | [meta/views.py](https://app.codecov.io/gh/nephila/django-meta/pull/156?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nephila#diff-bWV0YS92aWV3cy5weQ==) | `98.10% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.