search

nephila / django-meta

Pluggable app to allow Django developers to quickly add meta tags and OpenGraph, Twitter, and Google Plus properties to their HTML responses.
https://django-meta.readthedocs.io
Other
477 stars 68 forks source link

Refactor settings to make override_settings in tests more consistent #168

Closed protoroto closed 1 year ago

protoroto commented 1 year ago

Description

Refactor settings to make override_settings in tests more consistent

References

Fix #167

Checklist

coveralls commented 1 year ago

Coverage Status

coverage: 98.272% (+0.01%) from 98.261% when pulling 9d110fdf0e436a96a8892d10b9138c065721d1d0 on protoroto:feature/issue-167-refactor-settings into 0ac87d359dacec8c97fed204c533c27b56a44fd3 on nephila:develop.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% :tada:

Comparison is base (0ac87d3) 97.60% compared to head (9d110fd) 97.62%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #168 +/- ## =========================================== + Coverage 97.60% 97.62% +0.01% =========================================== Files 8 8 Lines 460 463 +3 Branches 78 79 +1 =========================================== + Hits 449 452 +3 Misses 8 8 Partials 3 3 ``` | [Flag](https://app.codecov.io/gh/nephila/django-meta/pull/168/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nephila) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/nephila/django-meta/pull/168/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nephila) | `97.40% <100.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nephila#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/nephila/django-meta/pull/168?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nephila) | Coverage Δ | | |---|---|---| | [meta/models.py](https://app.codecov.io/gh/nephila/django-meta/pull/168?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nephila#diff-bWV0YS9tb2RlbHMucHk=) | `93.97% <100.00%> (-0.08%)` | :arrow_down: | | [meta/settings.py](https://app.codecov.io/gh/nephila/django-meta/pull/168?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nephila#diff-bWV0YS9zZXR0aW5ncy5weQ==) | `100.00% <100.00%> (ø)` | | | [meta/templatetags/meta.py](https://app.codecov.io/gh/nephila/django-meta/pull/168?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nephila#diff-bWV0YS90ZW1wbGF0ZXRhZ3MvbWV0YS5weQ==) | `100.00% <100.00%> (ø)` | | | [meta/views.py](https://app.codecov.io/gh/nephila/django-meta/pull/168?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nephila#diff-bWV0YS92aWV3cy5weQ==) | `98.13% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.