nephila / django-meta

Pluggable app to allow Django developers to quickly add meta tags and OpenGraph, Twitter, and Google Plus properties to their HTML responses.
https://django-meta.readthedocs.io
Other
477 stars 68 forks source link

Removed unnecessary else statements. #180

Closed thesayfulla closed 10 months ago

thesayfulla commented 10 months ago

Description

Hello. I have removed unnecessary "else" statements. Please check my PR. Thank you!

References

Provide any github issue fixed (as in Fix #XYZ)

Checklist

coveralls commented 10 months ago

Coverage Status

coverage: 98.905%. remained the same when pulling c11a0e0dbe54cbc94593bb27504ebd17d4accf3d on thesayfulla:feature/removed_else_statements into 46583ef5b53bd10fe87c201deec94b12e870e923 on nephila:develop.

codecov[bot] commented 10 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (46583ef) 97.81% compared to head (c11a0e0) 97.81%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #180 +/- ## ======================================== Coverage 97.81% 97.81% ======================================== Files 8 8 Lines 548 548 Branches 99 99 ======================================== Hits 536 536 Misses 6 6 Partials 6 6 ``` | [Flag](https://app.codecov.io/gh/nephila/django-meta/pull/180/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nephila) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/nephila/django-meta/pull/180/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nephila) | `97.62% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nephila#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/nephila/django-meta/pull/180?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nephila) | Coverage Δ | | |---|---|---| | [meta/models.py](https://app.codecov.io/gh/nephila/django-meta/pull/180?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nephila#diff-bWV0YS9tb2RlbHMucHk=) | `94.89% <100.00%> (ø)` | | | [meta/views.py](https://app.codecov.io/gh/nephila/django-meta/pull/180?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nephila#diff-bWV0YS92aWV3cy5weQ==) | `98.23% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

protoroto commented 10 months ago

Hi! Thanks for this pr! :) In order to be able to merge it, we need a couple of things:

All these passages are needed for the CI to pass, and for us to include easily your change in next release. Feel free to ask questions if I've not explained myself or if you need more info. Thanks again!

thesayfulla commented 10 months ago

Hi! Thanks for this pr! :) In order to be able to merge it, we need a couple of things:

  • you should open an issue (something like "Remove useless else statements", and mark it as "Feature request"
  • rename your branch like stated in the contribution guidelines (like feature/issue-<number-of-the-issue-you-opened>-remove-useless-else-statements
  • add a new file in the changes directory named <number-of-the-issue-you-opened>.feature with the commit message as content

All these passages are needed for the CI to pass, and for us to include easily your change in next release. Feel free to ask questions if I've not explained myself or if you need more info. Thanks again!

Thank you for replying :)

I will do it.