search

nephila / django-meta

Pluggable app to allow Django developers to quickly add meta tags and OpenGraph, Twitter, and Google Plus properties to their HTML responses.
https://django-meta.readthedocs.io
Other
481 stars 68 forks source link

Fix MetadataMixin.use_use_title_tag -> MetadataMixin.use_title_tag #62

Closed EmiM closed 6 years ago

EmiM commented 7 years ago

I suppose it's a bug. It escalated when I didn't call 'super' in my class using MetadataMixin ->

AttributeError: 'MyClass' object has no attribute 'use_title_tag'

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 98.028% when pulling d698af3ac205cf00e6b0a122a41700e02aff7c3e on EmiM:develop into 643d41f4cb1c354d799803bcfe420501f2a0889f on nephila:develop.

codecov[bot] commented 7 years ago

Codecov Report

Merging #62 into develop will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop     #62   +/-   ##
=======================================
  Coverage     96.9%   96.9%           
=======================================
  Files            7       7           
  Lines          355     355           
  Branches        38      38           
=======================================
  Hits           344     344           
  Misses           7       7           
  Partials         4       4

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 643d41f...d698af3. Read the comment docs.

yakky commented 6 years ago

@EmiM oh my! Thanks for spotting this!