nephila / django-meta

Pluggable app to allow Django developers to quickly add meta tags and OpenGraph, Twitter, and Google Plus properties to their HTML responses.

https://django-meta.readthedocs.io

Other

481 stars 68 forks source link

Add optional request argument to Meta #68

Closed yakky closed 6 years ago

yakky commented 6 years ago

Fix #65

yakky commented 6 years ago

@protoroto could you have a look at this?

coveralls commented 6 years ago

Coverage increased (+0.6%) to 98.596% when pulling 025bf4dfcbce31f58df3de34e3c7ffbfa60f88c3 on feature/meta_requests into 4789c6e86bd41d39f9eb50628a4d60ef730998a8 on develop.

codecov[bot] commented 6 years ago

Codecov Report

Merging #68 into develop will not change coverage. The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop      #68   +/-   ##
========================================
  Coverage    97.34%   97.34%           
========================================
  Files            4        4           
  Lines          113      113           
  Branches        11       11           
========================================
  Hits           110      110           
  Misses           2        2           
  Partials         1        1

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 23ec6d5...55c2d60. Read the comment docs.

coveralls commented 6 years ago

Coverage increased (+0.6%) to 98.596% when pulling 3c3d9933a03de004d1664d31d487f71a5d10d4d8 on feature/meta_requests into 23ec6d50239d69f1812aaefb3d4577992ef4a6d5 on develop.

coveralls commented 6 years ago

Coverage increased (+0.6%) to 98.596% when pulling 3c3d9933a03de004d1664d31d487f71a5d10d4d8 on feature/meta_requests into 23ec6d50239d69f1812aaefb3d4577992ef4a6d5 on develop.

coveralls commented 6 years ago

Coverage increased (+0.6%) to 98.596% when pulling 3c3d9933a03de004d1664d31d487f71a5d10d4d8 on feature/meta_requests into 23ec6d50239d69f1812aaefb3d4577992ef4a6d5 on develop.

coveralls commented 6 years ago

Coverage increased (+0.6%) to 98.596% when pulling 3c3d9933a03de004d1664d31d487f71a5d10d4d8 on feature/meta_requests into 23ec6d50239d69f1812aaefb3d4577992ef4a6d5 on develop.

coveralls commented 6 years ago

Coverage increased (+0.6%) to 98.599% when pulling 55c2d606b86af9d2d3af7ba3a93f873188220bea on feature/meta_requests into 23ec6d50239d69f1812aaefb3d4577992ef4a6d5 on develop.

yakky commented 6 years ago

Thanks for your review @Paul424 ! Merging this soon and releasing a new version early next week

protoroto commented 6 years ago

Looks good to me too @yakky