search

nephila / django-meta

Pluggable app to allow Django developers to quickly add meta tags and OpenGraph, Twitter, and Google Plus properties to their HTML responses.
https://django-meta.readthedocs.io
Other
481 stars 68 forks source link

Add image size for facebook sharing #91

Closed peleccom closed 5 years ago

peleccom commented 5 years ago

According to Facebook documentation

https://developers.facebook.com/docs/sharing/best-practices/?locale=en_US#precaching

adding og:image:width and og:image:height properties will help facebook crawler to figure out right image dimensions. It will render the shared image at the first post sharing.

Currently, the first person who shares the post doesn't see the image. The image becomes available after the second post.

codecov[bot] commented 5 years ago

Codecov Report

Merging #91 into develop will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #91   +/-   ##
========================================
  Coverage    97.43%   97.43%           
========================================
  Files            4        4           
  Lines          117      117           
  Branches        12       12           
========================================
  Hits           114      114           
  Misses           2        2           
  Partials         1        1

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c8598d7...d7739da. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #91 into develop will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #91   +/-   ##
========================================
  Coverage    97.43%   97.43%           
========================================
  Files            4        4           
  Lines          117      117           
  Branches        12       12           
========================================
  Hits           114      114           
  Misses           2        2           
  Partials         1        1

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c8598d7...d7739da. Read the comment docs.

yakky commented 5 years ago

@peleccom thanks for contributing this!