search

nephila / django-meta

Pluggable app to allow Django developers to quickly add meta tags and OpenGraph, Twitter, and Google Plus properties to their HTML responses.
https://django-meta.readthedocs.io
Other
481 stars 68 forks source link

Replace `meta.html` with a more maintenable / extendable approach #94

Open yakky opened 5 years ago

yakky commented 5 years ago

meta.html is quite burdensome to support, as any change to will require people who extended it to adapt.

We will likely need a more robust solution that will allow people to extend it, without the need to change it everytime we add more tags

lggwettmann commented 5 years ago

Same issue here. I'm just adding unsupported meta tags manually in the template now cause django-meta doesnt support the Facebook/OpenGraph metatags/microtags for product catalog registration. Would be great if one could just add new tags via the MetaMixin.

yakky commented 5 years ago

@lggwettmann thanks for the feedback. You can also add custom tags via extra_props, extra_custom_props https://django-meta.readthedocs.io/en/latest/views.html#extra-props

lggwettmann commented 5 years ago

Tried that, but didn't show up in the meta tags.

lggwettmann commented 5 years ago

Would it perhaps be an idea to start implementing the JSON-LD instead or as an addition to the basic meta tags? I could imagine that that would bring quite an advantage nowadays and should be (?) more extendable? I haven't done much research and just stumbled upon JSON-LD though.

yakky commented 5 years ago

JSON-LD support is in the works in #76 My goal is to implement less tags and allow people to have a simple way to add the tags they care about :)

yakky commented 5 years ago

Tried that, but didn't show up in the meta tags.

@lggwettmann are you using views or models?

yakky commented 5 years ago

@lggwettmann you may want to check #95 (and https://github.com/nephila/django-meta/pull/95/files#diff-823680934ff274e0f1ecdacdf80a9f61R3 in detail) regarding implementing extra / custom tags properties