nephila / djangocms-blog

django CMS blog application - Support for multilingual posts, placeholders, social network meta tags and configurable apphooks
https://djangocms-blog.readthedocs.io
BSD 3-Clause "New" or "Revised" License
403 stars 190 forks source link

Improve meta image size handling #718

Closed adrien-delhorme closed 1 year ago

adrien-delhorme commented 1 year ago

Description

Use a thumbnailer on the meta image field, that uses a BLOG_META_IMAGE_SIZE thumbnail option setting with a default size of 1600x1600px (facebook recommended size)

References

Fix #718

Checklist

yakky commented 1 year ago

@adrien-delhorme I agree we need this, I'd ask to changes the behavior to set the default value for BLOG_META_IMAGE_SIZE to None and the method should fallback to the current behavior if the setting value isNone

yakky commented 1 year ago

@adrien-delhorme develop is now back in shape and pipeline is working good, could you please update this PR? thanks a lot

yakky commented 1 year ago

@adrien-delhorme we cherry-picked the relevant commit with #743 can you make a quick review of the new PR?

adrien-delhorme commented 1 year ago

I found a tiny typo in a code comment, but it is not important. Ok for this one! Thanks again! 🙏