search

nephila / djangocms-blog

django CMS blog application - Support for multilingual posts, placeholders, social network meta tags and configurable apphooks
https://djangocms-blog.readthedocs.io
BSD 3-Clause "New" or "Revised" License
391 stars 192 forks source link

Fix distinct preventing post delete from admin #735

Closed yakky closed 1 year ago

yakky commented 1 year ago

Description

Unneeded distinct call in PostAdmin.get_queryset breaks post deletion under django 3.2+

References

Fix #683

Checklist

coveralls commented 1 year ago

Coverage Status

Coverage: 96.961%. Remained the same when pulling f9c5341520743e70d396751f3fc7f087a3feac59 on bugfix/issue-683-distinct-delete into cc544feec74338d9fef364f5fb2f11c60a199223 on develop.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (cc544fe) 94.24% compared to head (f9c5341) 94.24%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #735 +/- ## ======================================== Coverage 94.24% 94.24% ======================================== Files 26 26 Lines 1823 1823 Branches 260 260 ======================================== Hits 1718 1718 Misses 53 53 Partials 52 52 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `94.24% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nephila#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/nephila/djangocms-blog/pull/735?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nephila) | Coverage Δ | | |---|---|---| | [djangocms\_blog/admin.py](https://app.codecov.io/gh/nephila/djangocms-blog/pull/735?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nephila#diff-ZGphbmdvY21zX2Jsb2cvYWRtaW4ucHk=) | `83.06% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.