nephila / djangocms-blog

django CMS blog application - Support for multilingual posts, placeholders, social network meta tags and configurable apphooks
https://djangocms-blog.readthedocs.io
BSD 3-Clause "New" or "Revised" License
391 stars 192 forks source link

Fix template urls not respecting namespaces #744

Closed protoroto closed 11 months ago

protoroto commented 11 months ago

Description

Fix template urls not respecting namespaces: Before that, all plugins were outputting wrong urls if two different configs were present, ignoring the app config selected in plugins.

References

Fix #723

Checklist

coveralls commented 11 months ago

Coverage Status

coverage: 97.115%. remained the same when pulling 94520a42b3e4ebe8732799789505b59677e0ed8f on protoroto:bugfix/issue-723-respect-namespace-in-template-urls into 326ae7afa0ae19b34436bd1e41e52b1d82c9f6f2 on nephila:develop.

codecov[bot] commented 11 months ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (326ae7a) 94.28% compared to head (94520a4) 94.28%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #744 +/- ## ======================================== Coverage 94.28% 94.28% ======================================== Files 26 26 Lines 1837 1837 Branches 263 263 ======================================== Hits 1732 1732 Misses 53 53 Partials 52 52 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `94.28% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nephila#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

protoroto commented 11 months ago

@i-salameh95 could you please check if this pr fixes #723 issue? We are not filtering the categories queryset based on namespace (it involves adding js to reload the form on every select change, and I'm not entirely sure that it is the behaviour we want), but the urls in templates should be correct now