marksweb commented 6 years ago

Fix for i18n url patterns (Fix #321)

coveralls commented 6 years ago

Changes Unknown when pulling 8f8e8d0d161372354374b9188eb612cffdcd2bd2 on marksweb:feature/non-i18n-urls into on nephila:develop.

codecov[bot] commented 6 years ago

Codecov Report

Merging #322 into develop will increase coverage by 0.02%. The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #322      +/-   ##
===========================================
+ Coverage    90.76%   90.79%   +0.02%     
===========================================
  Files            7        7              
  Lines          639      641       +2     
  Branches       133      134       +1     
===========================================
+ Hits           580      582       +2     
  Misses          27       27              
  Partials        32       32

Impacted Files	Coverage Δ
djangocms_installer/django/__init__.py	`89.78% <100%> (+0.08%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eae9463...85b994d. Read the comment docs.

yakky commented 6 years ago

It looks good at first sight. I'll check more thoroughly later today As for the coverage, we can safely exclude urlconfs from coverage by adding them to coverage configuration

marksweb commented 6 years ago

Yeah based on this I'll have a look at potential for more tests as well, but might be moving offices today so will have to see if I've got some free time!

coveralls commented 6 years ago

Changes Unknown when pulling 85b994d70f9f7718b6a8a549c55019a6cdba3c62 on marksweb:feature/non-i18n-urls into on nephila:develop.

yakky commented 6 years ago

I don't think we need more tests I'm going to merge this, thanks for working on this :+1:

nephila / djangocms-installer

Feature/non i18n urls #322

Codecov Report