search

nephila / djangocms-installer

Console wizard to bootstrap django CMS projects
https://djangocms-installer.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
177 stars 78 forks source link

Update html5lib preventing error #334

Closed lucidcyborg closed 5 years ago

lucidcyborg commented 5 years ago

I kept getting the error while installing so I thought I'ld fix it.

codecov[bot] commented 5 years ago

Codecov Report

Merging #334 into develop will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #334   +/-   ##
========================================
  Coverage    91.14%   91.14%           
========================================
  Files            7        7           
  Lines          644      644           
  Branches       134      134           
========================================
  Hits           587      587           
  Misses          26       26           
  Partials        31       31
Impacted Files Coverage Δ
djangocms_installer/config/data.py 100% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 11f3fda...d04a08f. Read the comment docs.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 94.745% when pulling d04a08fc0cb55ecdc85e18ba9545cf4ac562eebc on mquellhorst:develop into 11f3fdaf9fd07e619d735f7a1ca564a0acac4d64 on nephila:develop.

yakky commented 5 years ago

@mquellhorst thanks for this! Could I ask you to also bump djangocms-text-ckeditor dependency to 3.6.1 for django CMS 3.4 and 3.5? There is also some version check in tests/config.py to be changed in this case

yakky commented 5 years ago

@mquellhorst thanks, I am applying this together with some further changes in #335