yakky commented 5 years ago

if DJANGO_SETTINGS_MODULE is set in a way which is incompatible with django CMS installer, the install will fail with obscure errors

By checking on start, we can ensure to return a clearer error message to the user

Fix #330

codecov[bot] commented 5 years ago

Codecov Report

Merging #338 into develop will increase coverage by 0.22%. The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #338      +/-   ##
===========================================
+ Coverage     90.7%   90.92%   +0.22%     
===========================================
  Files            7        7              
  Lines          656      661       +5     
  Branches       139      140       +1     
===========================================
+ Hits           595      601       +6     
  Misses          28       28              
+ Partials        33       32       -1

Impacted Files	Coverage Δ
djangocms_installer/config/__init__.py	`91.01% <100%> (+0.83%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 85238dd...cdaf72f. Read the comment docs.

coveralls commented 5 years ago

Coverage increased (+0.03%) to 95.783% when pulling cdaf72ff7ed05193760984fe3bcfd7b9c0426f79 on feature/detect_settings_module_env into 85238ddbb28c8500a079734303304ef434efc623 on develop.

nephila / djangocms-installer

Detect incompatible DJANGO_SETTINGS_MODULE #338

Codecov Report