nephila / djangocms-installer

Console wizard to bootstrap django CMS projects

https://djangocms-installer.readthedocs.io/

BSD 3-Clause "New" or "Revised" License

177 stars 78 forks source link

Improve settings patching #339

Closed yakky closed 5 years ago

yakky commented 5 years ago

If for some reason the installed django version is different than the declared one, an invalid configuration might be generated due switch between tuple and list in django 1.9

This tries to detect the version mismatch and report a meaningful error, ending the installation

Fix #329

coveralls commented 5 years ago

Coverage remained the same at ?% when pulling a22e23d82c4fcdbfbfcafd83ebd2920bcd8c2da1 on feature/improve-settings into 212a27e8c60068db6a5e7e7a8e7d6d68d91355f7 on develop.

coveralls commented 5 years ago

Coverage remained the same at ?% when pulling a22e23d82c4fcdbfbfcafd83ebd2920bcd8c2da1 on feature/improve-settings into 212a27e8c60068db6a5e7e7a8e7d6d68d91355f7 on develop.

coveralls commented 5 years ago

Coverage decreased (-1.2%) to 94.627% when pulling 29dd5524b2c3fb0b113da2c1bb8f6bb5d9282b98 on feature/improve-settings into 212a27e8c60068db6a5e7e7a8e7d6d68d91355f7 on develop.

codecov[bot] commented 5 years ago

Codecov Report

Merging #339 into develop will increase coverage by 0.08%. The diff coverage is 93.75%.

@@             Coverage Diff             @@
##           develop     #339      +/-   ##
===========================================
+ Coverage    90.77%   90.85%   +0.08%     
===========================================
  Files            7        7              
  Lines          661      667       +6     
  Branches       140      141       +1     
===========================================
+ Hits           600      606       +6     
  Misses          28       28              
  Partials        33       33

Impacted Files	Coverage Δ
djangocms_installer/config/__init__.py	`90.44% <100%> (ø)`	:arrow_up:
djangocms_installer/config/ini.py	`88.31% <100%> (ø)`	:arrow_up:
djangocms_installer/django/__init__.py	`90.12% <92.85%> (+0.25%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 212a27e...29dd552. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #339 into develop will increase coverage by 0.08%. The diff coverage is 93.75%.

@@             Coverage Diff             @@
##           develop     #339      +/-   ##
===========================================
+ Coverage    90.77%   90.85%   +0.08%     
===========================================
  Files            7        7              
  Lines          661      667       +6     
  Branches       140      141       +1     
===========================================
+ Hits           600      606       +6     
  Misses          28       28              
  Partials        33       33

Impacted Files	Coverage Δ
djangocms_installer/config/ini.py	`88.31% <100%> (ø)`	:arrow_up:
djangocms_installer/config/__init__.py	`90.44% <100%> (ø)`	:arrow_up:
djangocms_installer/django/__init__.py	`90.12% <92.85%> (+0.25%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 212a27e...29dd552. Read the comment docs.