nephila / djangocms-installer

Console wizard to bootstrap django CMS projects

https://djangocms-installer.readthedocs.io/

BSD 3-Clause "New" or "Revised" License

177 stars 78 forks source link

Fix starting page script for django CMS 3.5+ #348

Closed yakky closed 5 years ago

yakky commented 5 years ago

Fixes home page not published when creating the starting page (see https://github.com/nephila/djangocms-installer/issues/333#issuecomment-506994251)

codecov[bot] commented 5 years ago

Codecov Report

Merging #348 into release/1.1.x will not change coverage. The diff coverage is n/a.

@@              Coverage Diff               @@
##           release/1.1.x     #348   +/-   ##
==============================================
  Coverage          90.93%   90.93%           
==============================================
  Files                  7        7           
  Lines                673      673           
  Branches             142      142           
==============================================
  Hits                 612      612           
  Misses                28       28           
  Partials              33       33

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 144145e...6c3467a. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #348 into release/1.1.x will not change coverage. The diff coverage is n/a.

@@              Coverage Diff               @@
##           release/1.1.x     #348   +/-   ##
==============================================
  Coverage          90.93%   90.93%           
==============================================
  Files                  7        7           
  Lines                673      673           
  Branches             142      142           
==============================================
  Hits                 612      612           
  Misses                28       28           
  Partials              33       33

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 144145e...6c3467a. Read the comment docs.

coveralls commented 5 years ago

Coverage remained the same at 95.858% when pulling 6c3467ab7c110d8097a571fb2dc1b1ced0f39b47 on hotfix/starting-page into 144145e9a9bce43d7b9043e0464030c57249ad03 on release/1.1.x.

greyhare commented 5 years ago

Bug is fixed. http://127.0.0.1:8000/en/ properly displays the starting page.

yakky commented 5 years ago

Thanks for the feedback @greyhare

albertcunill commented 3 years ago

is it possible this fix is not merged in the latest release (1.2.3)?