search

nephila / djangocms-installer

Console wizard to bootstrap django CMS projects
https://djangocms-installer.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
177 stars 78 forks source link

optional argument --bootstrap with value no install djangocms-bootstrap4 #392

Closed michalnik closed 2 years ago

michalnik commented 2 years ago

Description

When I want to use optional argument --bootstrap no it should not install djangocms-bootstrap4.

Steps to reproduce

$ python3.7 -m venv env $ source env/bin/activate $ pip install --upgrade pip $ pip install pytz djangocms-installer $ djangocms -f --bootstrap no -s -p . someapp

Versions

python3.7, django3.1.14, pytz2021.3, djangocms-installer2.0.0

Expected behaviour

1) the requirements.txt file should not contain djangocms-bootstrap4 2) the someapp/settings.py should not have INSTALLED_APPS with these apps included

'djangocms_icon', 'djangocms_link', 'djangocms_picture', 'djangocms_bootstrap4', 'djangocms_bootstrap4.contrib.bootstrap4_alerts', 'djangocms_bootstrap4.contrib.bootstrap4_badge', 'djangocms_bootstrap4.contrib.bootstrap4_card', 'djangocms_bootstrap4.contrib.bootstrap4_carousel', 'djangocms_bootstrap4.contrib.bootstrap4_collapse', 'djangocms_bootstrap4.contrib.bootstrap4_content', 'djangocms_bootstrap4.contrib.bootstrap4_grid', 'djangocms_bootstrap4.contrib.bootstrap4_jumbotron', 'djangocms_bootstrap4.contrib.bootstrap4_link', 'djangocms_bootstrap4.contrib.bootstrap4_listgroup', 'djangocms_bootstrap4.contrib.bootstrap4_media', 'djangocms_bootstrap4.contrib.bootstrap4_picture', 'djangocms_bootstrap4.contrib.bootstrap4_tabs', 'djangocms_bootstrap4.contrib.bootstrap4_utilities',

Actual behaviour

It is opposite of expected behavior.

Additional information

I don't know what else I should put here.

michalnik commented 2 years ago

I was looking into source code and it seems that option --bootstrap has quite different meaning that I was thinking a while ago. When it is "yes" there will be CMS_TEMPLATES_BOOTSTRAP and otherwise there will be CMS_TEMPLATES. Could somebody explain what should mean this option? The solution seems to be fix the help for the option? Thank somebody to help with it.

michalnik commented 2 years ago

So, it looks that this option is only about templates with or without css from this project. I would appreciate help, what I should do with this ... Thanx

michalnik commented 2 years ago

No answer, here. I am closing the ticket, cause there is no advice to help to find any solution.