graceful handling of unset settings

nephila / djangocms-multisite

django-multisite support for DjangoCMS

BSD 3-Clause "New" or "Revised" License

26 stars 19 forks source link

Closed stefanfoulis closed 7 years ago

stefanfoulis commented 7 years ago

Use blank defaults for MULTISITE_CMS_URLS, MULTISITE_CMS_ALIASES and MULTISITE_CMS_FALLBACK to minimise required configuration

Also: Always patch_vary_headers on Host

Chive commented 7 years ago

I'd prefer to have these 3 settings loaded at either class or even module level to decrease the amount of those lookups.

Apart from that: LGTM

stefanfoulis commented 7 years ago

Lookups in the method are on purpose, because it makes testing easier. Performance impact should be negligible.

yakky commented 7 years ago

@stefanfoulis what's the status of this one? Is complete on your side?

Chive commented 7 years ago

@stefanfoulis but testing is done now no? I see no reason for keeping those there..