nephila / djangocms-page-meta

OpenGraph, Twitter Card and Google+ snippet tags for django CMS 3 pages

https://djangocms-page-meta.readthedocs.io/

BSD 3-Clause "New" or "Revised" License

59 stars 64 forks source link

Filer canonical url #68

Closed cstrap closed 7 years ago

cstrap commented 7 years ago

The idea is share the image using the filer_file.canonical_url if django-filer is configured otherwise use the filer_file.url property.

coveralls commented 7 years ago

Coverage remained the same at 87.603% when pulling 20db9507cac4815ac931119dc02270cba86fb17f on cstrap:filer-canonical-url into ece7f0e815ef4fd4354d545a3ab894b228600965 on nephila:develop.

coveralls commented 7 years ago

Coverage remained the same at 87.603% when pulling 20db9507cac4815ac931119dc02270cba86fb17f on cstrap:filer-canonical-url into ece7f0e815ef4fd4354d545a3ab894b228600965 on nephila:develop.

coveralls commented 7 years ago

Coverage remained the same at 87.603% when pulling 20db9507cac4815ac931119dc02270cba86fb17f on cstrap:filer-canonical-url into ece7f0e815ef4fd4354d545a3ab894b228600965 on nephila:develop.

coveralls commented 7 years ago

Coverage remained the same at 87.603% when pulling 20db9507cac4815ac931119dc02270cba86fb17f on cstrap:filer-canonical-url into ece7f0e815ef4fd4354d545a3ab894b228600965 on nephila:develop.

cstrap commented 7 years ago

I got the same errors on the develop branch :-( Could be an issue related to something that I totally ignore?

yakky commented 7 years ago

Nice one @cstrap ! Failures probably depends on django CMS changes in 3.4 I'll check those first

yakky commented 7 years ago

@cstrap fixed in #69 Could you rebase this after merge of above PR?

codecov-io commented 7 years ago

Codecov Report

Merging #68 into develop will not change coverage. The diff coverage is 0%.

@@           Coverage Diff            @@
##           develop      #68   +/-   ##
========================================
  Coverage    85.55%   85.55%           
========================================
  Files            8        8           
  Lines          367      367           
  Branches        47       47           
========================================
  Hits           314      314           
  Misses          42       42           
  Partials        11       11

Impacted Files	Coverage Δ
djangocms_page_meta/utils.py	`83.17% <0%> (ø)`	:arrow_up:
djangocms_page_meta/__init__.py
djangocms_page_meta/south_migrations/__init__.py	`100% <0%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3e2b283...28cb390. Read the comment docs.

coveralls commented 7 years ago

Coverage remained the same at 88.556% when pulling 28cb390222ebc8b88e33dcffab4f589159f062fb on cstrap:filer-canonical-url into 3e2b2837ba75d27c5221bf1ffcad6181065f790d on nephila:develop.

cstrap commented 7 years ago

Thanks!

yakky commented 7 years ago

Thanks to you @cstrap for spotting this and proposing this fix!