search

nephila / djangocms-page-meta

OpenGraph, Twitter Card and Google+ snippet tags for django CMS 3 pages
https://djangocms-page-meta.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
59 stars 64 forks source link

Crash on creating new pagetype with djangocms 3.5.2 #93

Closed vinitkumar closed 5 years ago

vinitkumar commented 6 years ago

Hi, I am encountering a crash when using this plugin with djangoCMS 3.5.2. Here is the stack trace.

File "/virtualenv/lib/python2.7/site-packages/djangocms_page_meta/cms_toolbars.py", line 52, in populate
    Break, identifier=PAGE_MENU_SECOND_BREAK) + 1
TypeError: unsupported operand type(s) for +: 'NoneType' and 'int'
rolandf commented 6 years ago

I confirm I have it too.

yakky commented 5 years ago

@vinitkumar @rolandf are you able to reproduce in later versions of django CMS 3.5.x branch? I can't reproduce in 3.5.2 anyway

Does the page have any permission on it? Is the user a superuser?

vinitkumar commented 5 years ago

@yakky If I remember correctly, the user was a superuser. Also, this is the fix in my fork to get it working with 3.5.2. https://github.com/SocialSchools/djangocms-page-meta/commit/79c6f2e57a574275993b445eaf1d3a5fa6005d94

yakky commented 5 years ago

@vinitkumar ok, I can't reproduce this, but I borrowed your fix and I'll merge it

Thanks for reporting!

vinitkumar commented 5 years ago

@yakky Thanks. Please let me know when you released to pypi, so that I can use it instead of my own fork.

yakky commented 5 years ago

@vinitkumar will do. Expect it by the end of the week. I want to merge in at least django CMS 3.6 compatibility feature before releasing