search

nephila / djangocms-page-sitemap

django CMS page extension to handle sitemap customization
BSD 3-Clause "New" or "Revised" License
9 stars 20 forks source link

Fix for DjangoCMS 3.5: Use cms.utils.conf for get_cms_setting #17

Closed carderm closed 6 years ago

carderm commented 6 years ago

ImportError: cannot import name get_cms_setting

codecov[bot] commented 6 years ago

Codecov Report

Merging #17 into develop will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           develop    #17   +/-   ##
======================================
  Coverage      100%   100%           
======================================
  Files            6      6           
  Lines          119    119           
  Branches         9      9           
======================================
  Hits           119    119
Impacted Files Coverage Δ
djangocms_page_sitemap/settings.py 100% <100%> (ø) :arrow_up:
djangocms_page_sitemap/cms_toolbars.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9b0813d...4c6b791. Read the comment docs.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 4c6b79153d6517ca05b1408e26d54f59a5e67efc on mcldev:develop into 9b0813db3cec992645dde8c83b88aed8c02a0e3f on nephila:develop.

yakky commented 6 years ago

@carderm thanks for fixing this!

matinfo commented 6 years ago

@yakky Please release for this Django-CMS 3.5 fix.

yakky commented 6 years ago

@matinfo I spotted a couple more things that needs to be fixed before being able to release a 3.5 compatible version. If all goes well I think I should be able to push the fixes today or tomorrow, and have a release in a couple of days